Migrate from YAML to TOML, Python to Rust for configuration #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Planning to update docs and README in a separate PR along with the version bump. It gives us some time after merging before we have to release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #123
This PR moves our configuration parsing to Rust, while maintaining the existing Python interface. This is a temporary situation while we work on porting the rest of the downstream code to Rust as well.
The primary user-facing change is that we are moving from YAML to TOML for configuration.
There is code in this PR that automatically migrates a YAML config file to TOML, in addition to the pre-existing auto-migrations for other field changes we've made. For almost all users the switchover should be automatic and transparent.