-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow prefixes in PropertyMapping #29
Comments
I think this is basically what I put into the MR one year ago... |
@gaurav please go ahead :) |
Oops: the duplicate and the ^^xsd:string were both a result of hasNationalArchivesIdentifier being a datatype property. Once I converted it into an object property, it turned into a URI and the duplicate went away. I've updated http://mappings.dbpedia.org/index.php/Template:PropertyMapping to display the prefix/suffix/transform and to include some basic documentation. I'll try to update some templates to use prefixes and suffixes: I've tried to set it up so that mappings containing these are categorized into http://mappings.dbpedia.org/index.php/Category:Mappings_using_prefix and http://mappings.dbpedia.org/index.php/Category:Mappings_using_suffix, but that doesn't seem to be working. |
I can see the categorization working. Got it fixed? |
I didn't do anything ... it just fixed itself :-P |
There are four cases to test:
For each case, we need to test both prefix and suffix. |
Properties tested:
|
When would the value ever be a DatatypeProperty? I tried to do something with http://mappings.dbpedia.org/index.php/Mapping_commons:Doi, but I think the mapping to a DatatypeProperty (doi:10.123abc/d) is overridding the mapping to an OntologyProperty (http://dx.doi.org/wiki/10.123abc/d). Apart from units, I can't think of a case where something would need to be prefixed or suffixed to a produce a non-URI (although I'm sure I'll come up with something thirty seconds after posting this update :-P). |
I cannot think of one either atm :) For testing this you can try it out with any string datatype
On Wed, Jul 23, 2014 at 7:07 AM, Gaurav Vaidya notifications@github.com
Kontokostas Dimitris |
Incidentally, http://mappings.dbpedia.org/index.php/Mapping_commons:Doi didn't work locally, so I think there is a problem with mapping the same value in two different ways, or maybe just how I did the mapping there. |
you mean it works with a single mapping in all different ways but not if On Sun, Jul 27, 2014 at 6:42 PM, Gaurav Vaidya notifications@github.com
Kontokostas Dimitris |
OKAY
I think that means we're good to go? I'll look at it again tomorrow and check. |
so it was it a bug before or a wrong mapping? On Mon, Jul 28, 2014 at 12:51 PM, Gaurav Vaidya notifications@github.com
Kontokostas Dimitris |
Ah, right. No, we don't have a working example for just prefix and just suffix on ObjectProperty. I'll try again. |
Ah, I knew I'd done prefixed ObjectProperties somewhere:
I've added a spurious suffix to an ObjectProperty at http://mappings.dbpedia.org/index.php/Mapping_commons:Flickr, but it's not working. I'll need to debug this further. |
@jimkont: Do you think it makes sense to add prefix/suffix code for ObjectProperties fas done in @2d6e3ff? It doesn't make much sense to have a prefix for URLs, but suffixes might make sense. Note that converting a text value into an ObjectProperty works fine (e.g. hasNationalArchivesIdentifier in http://mappings.dbpedia.org/index.php?title=Mapping_commons:NARA-image-full&oldid=36827): the problem is when the code can recognize a URL before it gets to us. @2d6e3ff fixes that, but I'm not sure if it's necessary. What do you think? |
Let's keep it I think. If it doesn't make sense, people won't use it. |
A lot of the work is already done -- I've pulled it into my repo as https://github.com/gaurav/extraction-framework/tree/feature/prefix_in_propertymapping -- but it might need checking.
The text was updated successfully, but these errors were encountered: