Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A valid unsubscribe package must contain at least one topic filter #74

Merged

Conversation

gausby
Copy link
Owner

@gausby gausby commented Aug 25, 2018

Updated the unsubscribe package test generator to not generate empty subscription packages as well.

If applied this should fix #69

Updated the unsubscribe package test generator to not generate empty
subscription packages as well.
@gausby gausby changed the base branch from master to next-release August 25, 2018 21:23
@coveralls
Copy link

coveralls commented Aug 25, 2018

Pull Request Test Coverage Report for Build 496

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 87.287%

Files with Coverage Reduction New Missed Lines %
lib/tortoise/connection/receiver.ex 2 84.38%
Totals Coverage Status
Change from base Build 482: -0.04%
Covered Lines: 563
Relevant Lines: 645

💛 - Coveralls

@gausby gausby merged commit c58b1a7 into next-release Aug 26, 2018
@gausby gausby deleted the ensure-unsubscribe-contain-at-least-one-topic-filter branch August 27, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants