Slightly speed up printing for the obase!=10 case #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mod per BcDig In the last iteration of the per BcDig print loop, acc is known to be less than pow, therefore the last div and mod operations can be skipped, resulting in a speed-up of about 2% in my tests.
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 99.88% 99.88% +<.01%
==========================================
Files 16 16
Lines 3409 3411 +2
==========================================
+ Hits 3405 3407 +2
Misses 4 4
Continue to review full report at Codecov.
|
|
Oh whoops. I did not notice this PR; I merged in the patch instead, though I did list you as the author of the commit. I hope that is okay. Closing since the code is already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last iteration of the per BcDig print loop, "acc" is known to be less than "pow", therefore the last div and mod operations can be skipped, resulting in a speed-up of about 2% in my tests.