Whitespace adjustment and removal of some unused variables #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not allocate one BcDig per character of the string passed in. For ibase between 11 and 26 (decimal) more than one BcDig may be needed to store the value expressed by BC_BASE_DIGS characters. Testing for that case will probably cause more overhead than just applying a fudge factor (not verified - special casing the ibase range that needs this factor and using a factor of 1.5 instead of 2 might be worth the extra code complexity).
This change improves "make test" performance by more than 2%.
This implementation is not optimized for speed, yet. I have plans to add copy-on-write semantics for BcNums (i.e. add a reference count and copy the BcNum only if its refcount is > 1 it is about to be modified). This version fails in the bc/stdin test, but diagnosing this problem will have to wait for tomorrow ...
Beyond the changes performed by the automatic merge, remove references to the constvals field in struct BcFunc.
FreeBSD uses strict checks for base system components and the build failed due to the compiler warnings being treated as errors in base.
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 99.73% 99.73% +<.01%
==========================================
Files 16 16
Lines 3431 3435 +4
==========================================
+ Hits 3422 3426 +4
Misses 9 9
Continue to review full report at Codecov.
|
|
I have already made these changes in my local branch. I just haven't pushed them yet. I will push them when I get home from work, and I will close this then to remind me. Thank you. |
|
Changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not know how to restrict the pull request to just the two commits I consider relevant (probably is the GIT way to create a temporary branch for that purpose?)
The relevant commits are:
ca56e06
684e3f6