Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve portability, enable build on Solaris SPARC. #27

Merged
merged 7 commits into from Jan 15, 2020
Merged

Improve portability, enable build on Solaris SPARC. #27

merged 7 commits into from Jan 15, 2020

Conversation

zv-io
Copy link
Contributor

@zv-io zv-io commented Jan 15, 2020

This series addresses some bugs found on Solaris as discussed with the author in IRC earlier today. The following systems have been "loosely" tested to compile and pass the non-external-bc test suite:

  • Solaris 10 [sun4u] (GCC 5.5.0) in both 32- and 64- bit modes;
  • Solaris 11 [sun4v] (GCC 4.8.2 and 7.5.0) in both 32- and 64- bit modes;

Note: Solaris 10 requires aliasing to a POSIX-compliant shell (e.g. /usr/xpg4/bin/sh) or modifying the top of any scripts citing /bin/sh to this value.

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          16       16           
  Lines        3496     3496           
=======================================
  Hits         3484     3484           
  Misses         12       12
Impacted Files Coverage Δ
src/bc/parse.c 100% <ø> (ø) ⬆️
src/parse.c 100% <ø> (ø) ⬆️
src/read.c 100% <ø> (ø) ⬆️
src/vm.c 99.59% <ø> (ø) ⬆️
src/main.c 100% <ø> (ø) ⬆️
src/num.c 99.41% <ø> (ø) ⬆️
src/lex.c 100% <ø> (ø) ⬆️
src/bc/bc.c 100% <ø> (ø) ⬆️
src/bc/lex.c 100% <ø> (ø) ⬆️
src/lang.c 97.33% <ø> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358951d...a756285. Read the comment docs.

Copy link
Owner

@gavinhoward gavinhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! Unfortunately, it needs some work before I can accept it. See reviews below.

functions.sh Show resolved Hide resolved
Makefile.in Show resolved Hide resolved
configure.sh Show resolved Hide resolved
configure.sh Show resolved Hide resolved
configure.sh Show resolved Hide resolved
configure.sh Show resolved Hide resolved
Makefile.in Show resolved Hide resolved
@gavinhoward gavinhoward merged commit 063a155 into gavinhoward:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants