Fix EOF behavior in interactive mode with history #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, EOF would re-process the previous line, read one more
line, then exit. This is because bc_history_line left the buffer
untouched in case of EOF, and the bc_vm_stdin loop reads the next
line before checking the
done
condition of the previous iteration.This fix also prevents reading past the end of the buffer if the
first user input is EOF, since in that case vec->len is still 0,
so (size_t)-1 is passed to bc_read_binary.