Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axes not fixed if 3-D smooths are present #73

Closed
StefanoMezzini opened this issue May 21, 2020 · 2 comments
Closed

Axes not fixed if 3-D smooths are present #73

StefanoMezzini opened this issue May 21, 2020 · 2 comments

Comments

@StefanoMezzini
Copy link

@StefanoMezzini StefanoMezzini commented May 21, 2020

draw does not allow scales = 'fixed' if ti() terms are plotted. It would be nice to be able to have a common axis for 2-D smooths (i.e. s()) and the z axis of ti() terms (i.e. the color scale).

plot_grid(draw(m, scales = 'fixed'),
          draw(m, scales = 'fixed', select = 1:3))

image

gavinsimpson added a commit that referenced this issue May 29, 2020
@gavinsimpson
Copy link
Owner

@gavinsimpson gavinsimpson commented May 29, 2020

Thanks @StefanoMezzini I have fixed the bug (the 1-d smooths should have been fixed but not the 2-d one). I have also adapted the code so that all plots will have a fixed scale now if requested.

@gavinsimpson
Copy link
Owner

@gavinsimpson gavinsimpson commented May 29, 2020

These changes will be in version 0.4.1 which I am packaging up for CRAN at the moment. So hopefully there in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.