Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confint not working for te smooths #88

Closed
tamas-ferenci opened this issue Sep 16, 2020 · 2 comments
Closed

confint not working for te smooths #88

tamas-ferenci opened this issue Sep 16, 2020 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@tamas-ferenci
Copy link

I thought that the following is a valid call to confint, but it doesn't seem to like it:

dat <- gamSim(1, n = 500, dist = "normal", scale = 2)
mod <- gam(y ~ te(x0, x1), data = dat, method = "REML")
confint(mod, parm = c("x1", "x2"), type = "confidence")
@gavinsimpson
Copy link
Owner

This seems to be an area where inconsistency has crept in; the original blog posts where I showed some of this stuff had parm be the name of a covariate, which didn't even make sense then properly but this clearly fails badly here. In newer functions I have used the default label that mgcv uses as a means for the user to identify smooth terms so I should do that for confint() too.

@gavinsimpson gavinsimpson self-assigned this Sep 21, 2020
@gavinsimpson gavinsimpson added the bug Something isn't working label Sep 21, 2020
@gavinsimpson gavinsimpson added this to the 0.5 milestone Sep 21, 2020
gavinsimpson added a commit that referenced this issue Sep 21, 2020
Still need to fix the issue that 2D smooths aren't handled yet!
@gavinsimpson
Copy link
Owner

Thanks for this @tamas-ferenci. This shouldn't have worked anyway, as I was restricting confidence intervals to 1d smooth only elsewhere in the code, but I removed that restriction also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants