Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatible Python 3 support. #15

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Conversation

Danilka
Copy link
Contributor

@Danilka Danilka commented Feb 20, 2018

I also cleaned up some code. I hope that's ok.

@bunop
Copy link
Contributor

bunop commented Feb 20, 2018

Nice Work! I like the pep8 coding style. The test failing in CI could be a transitory problem in EnsEMBL endpoint

@bunop bunop mentioned this pull request Feb 20, 2018
@gawbul
Copy link
Owner

gawbul commented Feb 21, 2018

Hi, @Danilka, thanks for the PR. Will have a look at the Travis build in see if I can figure out what the issue is. Will get this merged asap 👍

@Danilka
Copy link
Contributor Author

Danilka commented Feb 21, 2018

Thanks for the quick response guys!
I checked the tests, it is indeed EnsEMBL. It randomly spits out 500s when it feels like it. Both on API and curl side. We might want to consider to build in retries for these cases.

@gawbul
Copy link
Owner

gawbul commented Feb 21, 2018

Yeah, I was just testing this myself, and it was randomly not working for the info/genomes/taxonomy endpoint.

@gawbul gawbul merged commit 0e2a5ae into gawbul:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants