Use 'need_tag' as option name to prevent calling 'tag' method

[june29]

I try to use gon v6.0.1 with Rails v4.2.3. In my app, I met following error:

ActionView::Template::Error: wrong number of arguments (0 for 1..4)
    /Users/june29/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/actionview-4.2.3/lib/action_view/helpers/tag_helper.rb:74:in `tag'
    /Users/june29/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/gon-6.0.1/lib/gon/base.rb:26:in `render_data'
    /Users/june29/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/gon-6.0.1/lib/gon/helpers.rb:5:in `include_gon'
    /Users/june29/path/to/myapp/app/views/layouts/application.html.erb:29:in
...

The code _o.tag on this line calls tag method defined in ActionView.

script = Gon::Escaper.javascript_tag(script, _o.type, _o.cdata, _o.nonce) if _o.tag

So I want to rename option tag to solve this problem.

[gazay]

Great, Thank you!

[gazay]

I just not really understand why it happening? _o is an OpenStruct object, and don't have methods from ActionView

[june29]

Thank you for your response!

Can you see this problem on your environment? If you can, please try it.

[gazay]

We're using gon in our projects and I didn't see this problem after update. Anyway it's good to rename just to need_tag as tag option was excess. Can you provide full backtrace of error?

[june29]

Oh, I found out a new fact. In our Rails app context, OpenStruct class includes some Modules.

pry(Gon::Base)> OpenStruct.ancestors
=> [OpenStruct,
 Object,
 Sprockets::Rails::Helper,
 ActionView::Helpers::AssetTagHelper,
 ActionView::Helpers::TagHelper,
 ActionView::Helpers::OutputSafetyHelper,
 ActionView::Helpers::CaptureHelper,
 ActionView::Helpers::AssetUrlHelper,
 Minitest::Expectations,
 Metaclass::ObjectMethods,
 Mocha::ObjectMethods,
 PP::ObjectMixin,
 Delayed::MessageSending,
 ActiveSupport::Dependencies::Loadable,
 JSON::Ext::Generator::GeneratorMethods::Object,
 Kernel,
 BasicObject]

[gazay]

I see. Anyway it is a good pull request, thank you =)

[june29]

Thank you merging 😀