Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I have been working in a fork of your BXbot project. After the migration of GDAX API to Coinbase Pro API, a new Coinbase Pro Exchange Adapter is needed (you can check it here)
It works as the other exchanges, plus a "time-server-bias" that is needed in order to make work the private calls (you can check this issue I have open in my fork: DavidHuertas#2).
I have a question to make: ¿do you have in mind to add calls to the "fees" services in order to improve fees calculation further than keeping them in the "otherConfig" section of the "exchange.yaml" config file?
Thank you in advance, regards
David Huertas