Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/try mode #136

Merged
merged 10 commits into from
Mar 17, 2022
Merged

Feature/try mode #136

merged 10 commits into from
Mar 17, 2022

Conversation

MarcDahlem
Copy link
Contributor

Replaced the very limited current test adapter, with a try-mode adapter.

Changes/Improvements:

  • The new try-mode adapter tracks the created dummy orders, and fill them if the corresponding limit price is reached
  • Instead of sending all public api calls to bitstamp, the adapter to be used can be configured
  • All starting balances and currencies for the try-mode can be configured

@MarcDahlem MarcDahlem mentioned this pull request May 5, 2021
@gazbert gazbert linked an issue May 8, 2021 that may be closed by this pull request
@gazbert gazbert removed a link to an issue May 8, 2021
@gazbert gazbert added this to the Improved Test Adapter Release milestone May 8, 2021
@MarcDahlem
Copy link
Contributor Author

The PR should be ready?

@gazbert gazbert self-assigned this Mar 4, 2022
@gazbert
Copy link
Owner

gazbert commented Mar 17, 2022

Finally started getting this back to master - sorry @MarcDahlem , it's been a hectic couple of years! :-)

A few minor Checkstyle issues + README / Javadocs / config docs updates required...

It's low risk and does not affect existing functionality, so I'll probably merge to master and then make the fixes off of that.

1.4.0 release will then follow.

@gazbert
Copy link
Owner

gazbert commented Mar 17, 2022

Merging to master. Will fix the Checktyle issues there. And update the docs for the new feature etc.

@gazbert gazbert merged commit 17d3ad7 into gazbert:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants