Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ABI jobs in Github #230

Merged
merged 4 commits into from
Jun 29, 2020
Merged

Integrate ABI jobs in Github #230

merged 4 commits into from
Jun 29, 2020

Conversation

j-rivero
Copy link
Contributor

The pull request change how ABI jobs are triggered:

  • Before, it was a conditional step in compilation jobs if target branch was different than master
  • After: the abi job integrates itself in github calls only if the target branch is a supported branch (major version branches)

I'm leaving the same parameters as before to be able to run builds manually in the same way.

Testing:

Be careful to run dsl changes on Jenkins since they will affect production code. I've used my fork to check:

All DSL runs fine on my local system and the produced xml for branches seems fine to me.

Closes #191

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I haven't really tested it, but the SDFormat results look promising!

@j-rivero j-rivero merged commit 11d8992 into master Jun 29, 2020
@j-rivero j-rivero deleted the abi_integration_github branch June 29, 2020 17:23
@scpeters
Copy link
Contributor

scpeters commented Jun 30, 2020

@scpeters
Copy link
Contributor

it looks like that job doesn't have the GITHUB variable set, but it also isn't setting the SRC_BRANCH or DEST_BRANCH variables

@j-rivero
Copy link
Contributor Author

j-rivero commented Jun 30, 2020

it looks like that job doesn't have the GITHUB variable set,

Ouch, my bad sorry. I've merged #223 to help fixing it.

but it also isn't setting the SRC_BRANCH or DEST_BRANCH variables

I think it is a cosmetic thing for the build descriptions and should not stop of the build to be complete, although I need to fix it.

Seems to work now: Build Status

@scpeters
Copy link
Contributor

thanks for the quick fix!

@scpeters
Copy link
Contributor

I can't figure out why the following comment didn't start an ign-physics ABI checker job:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABI jobs into Github
3 participants