-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ABI jobs in Github #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I haven't really tested it, but the SDFormat results look promising!
I just tested the with gazebosim/sdformat#301, and it's not working:
https://build.osrfoundation.org/job/_dsl_sdformat/883/console |
it looks like that job doesn't have the |
Ouch, my bad sorry. I've merged #223 to help fixing it.
I think it is a cosmetic thing for the build descriptions and should not stop of the build to be complete, although I need to fix it. |
thanks for the quick fix! |
I can't figure out why the following comment didn't start an ign-physics ABI checker job: |
The pull request change how ABI jobs are triggered:
I'm leaving the same parameters as before to be able to run builds manually in the same way.
Testing:
Be careful to run dsl changes on Jenkins since they will affect production code. I've used my fork to check:
All DSL runs fine on my local system and the produced xml for branches seems fine to me.
Closes #191