Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Delete operation #31

Merged
merged 14 commits into from
Jun 8, 2023
Merged

Firestore: Delete operation #31

merged 14 commits into from
Jun 8, 2023

Conversation

marcoshuck
Copy link
Collaborator

This PR adds a new implementation in the Firestore repository, this time for the Delete operation.

@marcoshuck marcoshuck self-assigned this Jun 6, 2023
@marcoshuck marcoshuck requested a review from AlejoAsd June 7, 2023 14:41
AlejoAsd
AlejoAsd approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@AlejoAsd AlejoAsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I plan on approving after adding a test for deleteBatch.

repository/firestore/firestore.go Outdated Show resolved Hide resolved
repository/firestore/firestore.go Outdated Show resolved Hide resolved
repository/firestore/firestore.go Show resolved Hide resolved
repository/firestore/firestore.go Outdated Show resolved Hide resolved
repository/firestore/firestore.go Outdated Show resolved Hide resolved
repository/firestore/firestore.go Outdated Show resolved Hide resolved
AlejoAsd
AlejoAsd reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@AlejoAsd AlejoAsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I plan on approving after adding a test for deleteBatch.

@AlejoAsd AlejoAsd self-requested a review June 7, 2023 19:45
marcoshuck and others added 9 commits June 8, 2023 13:41
@marcoshuck @AlejoAsd
Update repository/firestore/firestore.go
6d8a2cc 
Co-authored-by: Alejo Carballude <alejocarballude@gmail.com>
Signed-off-by: Marcos Huck <marcoshuck@users.noreply.github.com>
@marcoshuck @AlejoAsd
Update repository/firestore/firestore.go
5366bb8 
Co-authored-by: Alejo Carballude <alejocarballude@gmail.com>
Signed-off-by: Marcos Huck <marcoshuck@users.noreply.github.com>
@marcoshuck @AlejoAsd
Update repository/firestore/firestore.go
a9e4d90 
Co-authored-by: Alejo Carballude <alejocarballude@gmail.com>
Signed-off-by: Marcos Huck <marcoshuck@users.noreply.github.com>
@marcoshuck @AlejoAsd
Update repository/firestore/firestore.go
593cd03 
Co-authored-by: Alejo Carballude <alejocarballude@gmail.com>
Signed-off-by: Marcos Huck <marcoshuck@users.noreply.github.com>
@marcoshuck @AlejoAsd
Update repository/firestore/firestore.go
1930b21 
Co-authored-by: Alejo Carballude <alejocarballude@gmail.com>
Signed-off-by: Marcos Huck <marcoshuck@users.noreply.github.com>
@marcoshuck
Add test case for delete batch
dd45667
@marcoshuck
Merge remote-tracking branch 'origin/feature/firestore_delete' into f…
9df475a 
…eature/firestore_delete
@marcoshuck
Improve test case
2f077c2
@marcoshuck
Fix test case
bde2e3b
@marcoshuck marcoshuck marked this pull request as ready for review June 8, 2023 18:08
@marcoshuck marcoshuck merged commit 6e32339 into main Jun 8, 2023
@marcoshuck marcoshuck deleted the feature/firestore_delete branch June 8, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlejoAsd AlejoAsd AlejoAsd approved these changes

Assignees

@marcoshuck marcoshuck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoshuck @AlejoAsd