Updates after the removal of Scene3D plugin #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
ahcorde
requested changes
Sep 13, 2022
|
|
||
| * `showTitleBar` if true it will show the blue title bar over the plugin with the name mentioned in the `<title>` tag. | ||
| * `state` is the state of the plugin it can be docked in its place using `docked` or it can be `floating`. |
There was a problem hiding this comment.
this one is also below. Remove?
There was a problem hiding this comment.
+1 for removing
Suggested change
| * `state` is the state of the plugin it can be docked in its place using `docked` or it can be `floating`. |
| #### Common used 3D scene controllers | ||
|
|
||
| To provide some minimal functionality and controls, a part of the 3D scene implemented by `MinimalScene`, | ||
| a [usual set of plugins](https://github.com/gazebosim/gz-sim/blob/ff1c82b41e548dfdc8076374f9500db2df2c35a1/examples/worlds/minimal_scene.sdf#L29-L128) can be copied from the `gz-sim` repository. |
There was a problem hiding this comment.
Suggested change
| a [usual set of plugins](https://github.com/gazebosim/gz-sim/blob/ff1c82b41e548dfdc8076374f9500db2df2c35a1/examples/worlds/minimal_scene.sdf#L29-L128) can be copied from the `gz-sim` repository. | |
| a [usual set of plugins](https://github.com/gazebosim/gz-sim/blob/gz-sim7/examples/worlds/minimal_scene.sdf#L29-L128) can be copied from the `gz-sim` repository. |
There was a problem hiding this comment.
I suggest we leave the commit in the url to guarantee the correct lines are referenced
jennuine
approved these changes
Nov 2, 2022
|
|
||
| * `showTitleBar` if true it will show the blue title bar over the plugin with the name mentioned in the `<title>` tag. | ||
| * `state` is the state of the plugin it can be docked in its place using `docked` or it can be `floating`. |
There was a problem hiding this comment.
+1 for removing
Suggested change
| * `state` is the state of the plugin it can be docked in its place using `docked` or it can be `floating`. |
| #### Common used 3D scene controllers | ||
|
|
||
| To provide some minimal functionality and controls, a part of the 3D scene implemented by `MinimalScene`, | ||
| a [usual set of plugins](https://github.com/gazebosim/gz-sim/blob/ff1c82b41e548dfdc8076374f9500db2df2c35a1/examples/worlds/minimal_scene.sdf#L29-L128) can be copied from the `gz-sim` repository. |
There was a problem hiding this comment.
I suggest we leave the commit in the url to guarantee the correct lines are referenced
|
@j-rivero would you be able to address the feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: gazebosim/garden-tutorial-party#2015
Following gazebosim/gz-gui#484 (comment)
Updates for https://gazebosim.org/docs/garden/sdf_worlds and the example SDF file: