ColladaLoader: fix cases where VERTEX and NORMAL share same polylist <p> #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ORMAL) * vcount.size() * 3. If both VERTEX and NORMAL have offset 0, then the length of polylist <p> is vcount.size() * 3. So use length of set(offset) as inputSize. This fix for cases where VERTEX and NROMAL share same vcounts, see gazebosim#2682 (comment)
iche033
approved these changes
Aug 15, 2020
|
@osrf-jenkins run tests please |
scpeters
changed the title
scpeters
changed the title
|
the windows and homebrew builds both got disconnected |
|
@osrf-jenkins run tests please |
scpeters
reviewed
Aug 25, 2020
|
|
||
| this->ProcessEventsAndDraw(mainWindow); | ||
|
|
||
| // There should be two triangles. |
There was a problem hiding this comment.
I'll update this comment and then merge, since CI looks fine
scpeters
approved these changes
Aug 25, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gazebo9 version of #2811
fix: #2682 (comment)