Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColladaLoader: fix cases where VERTEX and NORMAL share same polylist <p> #2825

Merged
merged 3 commits into from
Aug 25, 2020
Merged

ColladaLoader: fix cases where VERTEX and NORMAL share same polylist <p> #2825

merged 3 commits into from
Aug 25, 2020

Commits on Aug 14, 2020

  1. add test to check gazebo model generated by assimp4, see gazebosim#2682

    @k-okada
    k-okada committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    0ce8aff View commit details
    Browse the repository at this point in the history

  2. Length of polylist <p> is not the number of inputs (i.e. VERTEX and N… 

    …ORMAL) * vcount.size() * 3. If both VERTEX and NORMAL have offset 0, then the length of polylist <p> is vcount.size() * 3. So use length of set(offset) as inputSize. This fix for cases where VERTEX and NROMAL share same vcounts, see gazebosim#2682 (comment)
    @k-okada
    k-okada committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    404de3e View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. collada_visualization.cc: update comment 

    Signed-off-by: Steve Peters <scpeters@openrobotics.org>
    @scpeters
    scpeters committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    644988a View commit details
    Browse the repository at this point in the history