Check for SDF files containing sibling elements of the same type with the same name (Gazebo9) #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires SDFormat API change gazebosim/sdformat#580.
j-rivero
changed the title
j-rivero
changed the title
|
@osrf-jenkins run tests |
|
brew is blocked by osrf/homebrew-simulation#1487 |
|
abichecker is broken and needs gazebo-tooling/release-tools#470 . A valid build could be |
|
Windows CI: |
|
Hanging CI run should be the same than: |
jennuine
reviewed
Jun 9, 2021
jennuine
approved these changes
Jun 9, 2021
Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
several fires 🔥 are ongoing in the buildfarm making things hard. I'm fighting with them. Thanks Jenn |
|
CI is now happy. |
This was referenced Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite: this requires gazebosim/sdformat#580 . In Draft until then.The PR adds a check for SDF files containing sibling elements with the same type. This is part of the SDF specs but was not enforced or check until now in Gazebo.
Since this PR will change the output behavior in the series of Gazebo9 releases I'm adding a check for an environment variable
GAZEBO9_BACKWARDS_COMPAT_WARNINGS_ERRORSthat users can set to avoid this new behavior if users want to preserve current behavior.