Fix codeownders #155
Merged
Fix codeownders #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🏢 edifice
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
adlarkin
force-pushed
the
fix_codeowners
branch
from
41954e6
to
f0382f5
Compare
j-rivero
approved these changes
Feb 16, 2021
7 tasks
This was referenced Aug 2, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in #151 by mentioning codeowners across separate lines, resulting in the last codeowner taking precedence for notifications/review requests (more information about how CODEOWNERS files work can be found here). This PR places all codeowners on the same line so that all codeowners are notified/requested for review on new PRs.
Signed-off-by: Ashton Larkin ashton@openrobotics.org
Checklist
codecheckpassed (See contributing)to support the maintainers
Note to maintainers: Remember to use Squash-Merge