Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out-of-bounds access in sanitizeSlashes #303

Merged
merged 2 commits into from Feb 1, 2022

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Feb 1, 2022

Fixes #301

Before this fix:

  • Expected behavior: Tests build and run when -D_GLIBCXX_ASSERTIONS is set
  • Actual behavior: Test aborts due to out-of-bounds access

Steps to reproduce

git checkout ign-common4
CXXFLAGS=-D_GLIBCXX_ASSERTIONS cmake -B build -S . -DCMAKE_BUILD_TYPE=Debug
make -C build UNIT_Filesystem_TEST
./build/bin/UNIT_Filesystem_TEST
gdb -ex run ./build/bin/UNIT_Filesystem_TEST

Signed-off-by: Michael Carroll michael@openrobotics.org

Fixes #301

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Feb 1, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Feb 1, 2022
@mjcarroll mjcarroll self-assigned this Feb 1, 2022
@mjcarroll mjcarroll moved this from Inbox to In review in Core development Feb 1, 2022
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #303 (b9e4cc0) into ign-common3 (af625e2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common3     #303   +/-   ##
============================================
  Coverage        76.58%   76.58%           
============================================
  Files               73       73           
  Lines            10403    10403           
============================================
  Hits              7967     7967           
  Misses            2436     2436           
Impacted Files Coverage Δ
src/Filesystem.cc 76.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af625e2...b9e4cc0. Read the comment docs.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll merged commit 14c585a into ign-common3 Feb 1, 2022
@mjcarroll mjcarroll deleted the out_of_bounds_filesystem branch February 1, 2022 21:10
Core development automation moved this from In review to Done Feb 1, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants