Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 ➡️ 6 #242

Merged
merged 2 commits into from
Mar 25, 2022
Merged

4 ➡️ 6 #242

merged 2 commits into from
Mar 25, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from nkoenig as a code owner March 24, 2022 22:57
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 24, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Mar 24, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #242 (21ac0f9) into ign-fuel-tools6 (f98c839) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@                 Coverage Diff                 @@
##           ign-fuel-tools6     #242      +/-   ##
===================================================
+ Coverage            75.39%   75.42%   +0.02%     
===================================================
  Files                   20       20              
  Lines                 2829     2832       +3     
===================================================
+ Hits                  2133     2136       +3     
  Misses                 696      696              
Impacted Files Coverage Δ
src/Zip.cc 69.87% <75.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98c839...21ac0f9. Read the comment docs.

@chapulina chapulina moved this from Inbox to In review in Core development Mar 25, 2022
@chapulina chapulina merged commit bc22258 into ign-fuel-tools6 Mar 25, 2022
@chapulina chapulina deleted the chapulina/4_to_6 branch March 25, 2022 15:55
Core development automation moved this from In review to Done Mar 25, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants