Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing windows tests issue #231 #266

Merged

Conversation

Blast545
Copy link
Contributor

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

Temporary remedy for #231. This is a continuation of the issue described in #106 IIUC.

Summary

Disabled known to fail tests, in order to get CI green checks to clean the whole stack.

Checklist

  • Signed all commits for DCO
  • Added tests -> Actually disables tests on windows
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

PR jobs should be green, except windows with protobuf warnings.

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 requested a review from nkoenig as a code owner June 23, 2022 21:54
@Blast545 Blast545 self-assigned this Jun 23, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Jun 23, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 23, 2022
@Blast545 Blast545 moved this from Inbox to To do in Core development Jun 23, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #266 (787ff63) into ign-fuel-tools7 (b3c253c) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ign-fuel-tools7     #266   +/-   ##
================================================
  Coverage            73.82%   73.82%           
================================================
  Files                   20       20           
  Lines                 2862     2862           
================================================
  Hits                  2113     2113           
  Misses                 749      749           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c253c...787ff63. Read the comment docs.

@chapulina chapulina added the Windows Windows support label Jun 23, 2022
@chapulina
Copy link
Contributor

There's one more failing test: UNIT_ign_src_TEST

@chapulina chapulina moved this from To do to In review in Core development Jun 23, 2022
@Blast545
Copy link
Contributor Author

I don't see those in our buildfarm tracked jobs, I'll re-run the check to see if it's a new regression, a flaky one, or somehow only related to PR jobs.

Original build: https://build.osrfoundation.org/job/ign_fuel-tools-pr-win/239/
Manual re-run: https://build.osrfoundation.org/job/ign_fuel-tools-pr-win/242/

@Blast545
Copy link
Contributor Author

@ros-pull-request-builder retest this please

@Blast545
Copy link
Contributor Author

No test regressions on the PR jobs, merging, thanks for the review!

@Blast545 Blast545 merged commit f4ea843 into ign-fuel-tools7 Jun 30, 2022
Core development automation moved this from In review to Done Jun 30, 2022
@Blast545 Blast545 deleted the blast545/disable_windows_tests_common_path branch June 30, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress Windows Windows support
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants