Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running plugins with bad-er world name #111

Merged
merged 5 commits into from Aug 25, 2020

Conversation

chapulina
Copy link
Contributor

This is a redo of #107, which was reverted in #110.

It now also covers the use case where the worldNames property is not set.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the bug Something isn't working label Aug 19, 2020
@chapulina chapulina self-assigned this Aug 19, 2020
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Aug 19, 2020
@osrf-triage osrf-triage added this to Inbox in Core development Aug 19, 2020
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #111 into ign-gui2 will increase coverage by 0.50%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui2     #111      +/-   ##
============================================
+ Coverage     60.43%   60.94%   +0.50%     
============================================
  Files            16       16              
  Lines          2108     2138      +30     
============================================
+ Hits           1274     1303      +29     
- Misses          834      835       +1     
Impacted Files Coverage Δ
src/plugins/world_control/WorldControl.cc 79.48% <70.00%> (+1.13%) ⬆️
src/plugins/world_stats/WorldStats.cc 97.16% <100.00%> (+2.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c8f55...018efd2. Read the comment docs.

Core development automation moved this from Inbox to In review Aug 20, 2020
Copy link

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkoenig
Copy link
Contributor

nkoenig commented Aug 20, 2020

I think there might still be a problem. I see this error:

[GUI] [Wrn] [WorldControl.cc:173] Ignoring topic [/world/simple_cave_01/stats], world name different from []. Fix or remove your <stats_topic> tag.
Topic [/world//stats] is not valid.
[GUI] [Err] [WorldControl.cc:191] Failed to subscribe to [/world//stats]

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

I see this error:

Thanks, you found the one case that I didn't test 🙈 Fixed: 4bfc316

Copy link
Contributor

@nkoenig nkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thanks!

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit c4ac608 into ign-gui2 Aug 25, 2020
Core development automation moved this from In review to Done Aug 25, 2020
@chapulina chapulina deleted the chapulina/world_names_again branch August 25, 2020 21:07
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants