New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running plugins with bad-er world name #111
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gui2 #111 +/- ##
============================================
+ Coverage 60.43% 60.94% +0.50%
============================================
Files 16 16
Lines 2108 2138 +30
============================================
+ Hits 1274 1303 +29
- Misses 834 835 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think there might still be a problem. I see this error:
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Thanks, you found the one case that I didn't test 🙈 Fixed: 4bfc316 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, thanks!
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This is a redo of #107, which was reverted in #110.
It now also covers the use case where the
worldNames
property is not set.