New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using std::chrono instead of common::Time #116
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
We should check who's using those functions and make sure to update them before committing to deprecating them. I think here the only case is for the |
Signed-off-by: ahcorde <ahcorde@gmail.com>
…ics/ign-gui into ahcorde/std_chrono
Signed-off-by: ahcorde <ahcorde@gmail.com>
…ics/ign-gui into ahcorde/std_chrono
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 63.07% 63.13% +0.05%
==========================================
Files 20 20
Lines 2592 2596 +4
==========================================
+ Hits 1635 1639 +4
Misses 957 957
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…gui into ahcorde/std_chrono
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This PR is related with this issue gazebosim/gz-common#61. The idea it's to deprecate the class
common::Time
in favor ofstd::chrono
.Related with
Should I deprecate the methods/functions that use common:Time ?
Signed-off-by: ahcorde ahcorde@gmail.com