Improve fork experience #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #139 +/- ##
=========================================
Coverage 59.57% 59.57%
=========================================
Files 20 20
Lines 2471 2471
=========================================
Hits 1472 1472
Misses 999 999 Continue to review full report at Codecov.
|
ahcorde
approved these changes
Oct 20, 2020
|
@osrf-jenkins run tests please |
|
@osrf-jenkins run tests please |
1 similar comment
|
@osrf-jenkins run tests please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our GitHub actions haven't been running correctly for forks. This should fix all of them:
CI
CI only on
pushmeans that PRs from forks aren't tested. Addingpull_requestfixes forks, with the downside of triggering duplicated jobs for PRs coming from branches in this repo.Labeler
Resolves gazebo-tooling/pr-collection-labeler#4.
Uses the new pull_request_target event.
Tested here: gazebosim/testing#14
Triage
Like above, uses the new pull_request_target event.
Tested here: gazebosim/testing#15