Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin added signal, add PluginByName #249

Merged
merged 1 commit into from Jul 7, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

While reviewing gazebosim/gz-sim#793 I realized that the PluginAdded signal has been emitting empty strings all along.

This PR fixes that signal, and also adds the handy PluginByName function.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the bug Something isn't working label Jul 7, 2021
@chapulina chapulina requested a review from jennuine as a code owner July 7, 2021 01:05
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 7, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Jul 7, 2021
@chapulina chapulina moved this from Inbox to In review in Core development Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #249 (0891847) into ign-gui3 (5262650) will increase coverage by 0.01%.
The diff coverage is 87.50%.

❗ Current head 0891847 differs from pull request most recent head ce56239. Consider uploading reports for the commit ce56239 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui3     #249      +/-   ##
============================================
+ Coverage     65.70%   65.71%   +0.01%     
============================================
  Files            23       23              
  Lines          2828     2835       +7     
============================================
+ Hits           1858     1863       +5     
- Misses          970      972       +2     
Impacted Files Coverage Δ
src/Application.cc 84.59% <87.50%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5262650...ce56239. Read the comment docs.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment

src/Application.cc Outdated Show resolved Hide resolved
@chapulina chapulina enabled auto-merge (squash) July 7, 2021 14:01
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit 3468008 into ign-gui3 Jul 7, 2021
@chapulina chapulina deleted the chapulina/3/plugin_name branch July 7, 2021 14:19
Core development automation moved this from In review to Done Jul 7, 2021
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants