Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit ignition gui key events in minimal scene3D #268

Merged
merged 4 commits into from Aug 13, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 11, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

馃帀 Enhancement

Summary

Required by gazebosim/gz-sim#854

This PR emit KeyEvent using ignition gui events

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #268 (7c18560) into main (e8f54e3) will increase coverage by 0.43%.
The diff coverage is 48.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   64.79%   65.23%   +0.43%     
==========================================
  Files          32       32              
  Lines        4508     4513       +5     
==========================================
+ Hits         2921     2944      +23     
+ Misses       1587     1569      -18     
Impacted Files Coverage 螖
src/plugins/minimal_scene/MinimalScene.cc 60.44% <26.66%> (+3.09%) 猬嗭笍
src/Conversions.cc 100.00% <100.00%> (酶)
src/plugins/scene3d/Scene3D.cc 48.89% <0.00%> (+0.26%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5048b05...7c18560. Read the comment docs.

src/plugins/minimal_scene/MinimalScene.hh Outdated Show resolved Hide resolved
src/Conversions.cc Outdated Show resolved Hide resolved
src/plugins/minimal_scene/MinimalScene.cc Outdated Show resolved Hide resolved
src/Conversions.cc Show resolved Hide resolved
src/plugins/minimal_scene/MinimalScene.cc Outdated Show resolved Hide resolved
src/plugins/minimal_scene/MinimalScene.cc Outdated Show resolved Hide resolved
@chapulina chapulina moved this from Inbox to Fortress critical in Core development Aug 12, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina August 12, 2021 10:39
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Core development automation moved this from Fortress critical to In review Aug 13, 2021
chapulina
chapulina previously approved these changes Aug 13, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works for me! Pushed small tweaks in 7c18560

@chapulina chapulina enabled auto-merge (squash) August 13, 2021 00:13
@chapulina chapulina dismissed their stale review August 13, 2021 01:12

Removing my approval for now because of this issue: gazebosim/gz-sim#854 (review)

@chapulina chapulina moved this from In review to Fortress critical in Core development Aug 13, 2021
@chapulina
Copy link
Contributor

Retriggered the Jenkins Ubuntu build because there was a weird test failure:

/var/lib/jenkins/workspace/ignition_gui-ci-pr_any-ubuntu_auto-amd64/ign-gui/test/integration/scene3d.cc:331
Expected equality of these values:
  Qt::Key_A
    Which is: 65
  keyPressedValue
    Which is: 16777251

@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 13, 2021

Retriggered the Jenkins Ubuntu build because there was a weird test failure:

/var/lib/jenkins/workspace/ignition_gui-ci-pr_any-ubuntu_auto-amd64/ign-gui/test/integration/scene3d.cc:331
Expected equality of these values:
  Qt::Key_A
    Which is: 65
  keyPressedValue
    Which is: 16777251

It's flaky

@chapulina chapulina merged commit db6b225 into main Aug 13, 2021
@chapulina chapulina deleted the ahcorde/minimal_scene/keyEvent branch August 13, 2021 20:16
Core development automation moved this from Fortress critical to Done Aug 13, 2021
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃彲 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants