New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit ignition gui key events in minimal scene3D #268
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 64.79% 65.23% +0.43%
==========================================
Files 32 32
Lines 4508 4513 +5
==========================================
+ Hits 2921 2944 +23
+ Misses 1587 1569 -18
Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, works for me! Pushed small tweaks in 7c18560
Removing my approval for now because of this issue: gazebosim/gz-sim#854 (review)
Retriggered the Jenkins Ubuntu build because there was a weird test failure:
|
It's flaky |
Signed-off-by: ahcorde ahcorde@gmail.com
馃帀 Enhancement
Summary
Required by gazebosim/gz-sim#854
This PR emit KeyEvent using ignition gui events
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge