Fix render engine GUI name argument to be setted in the minimal scene #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 65.37% 65.35% -0.03%
==========================================
Files 32 32
Lines 4604 4618 +14
==========================================
+ Hits 3010 3018 +8
- Misses 1594 1600 +6
Continue to review full report at Codecov.
|
This was referenced Sep 17, 2021
chapulina
added
beta
chapulina
suggested changes
Sep 18, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
…tps://github.com/ignitionrobotics/ign-gui into ahcorde/minimal_scene/render_engine_gui_argument
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
deleted the
ahcorde/minimal_scene/render_engine_gui_argument
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
Summary
This PR will set the render engine GUI name as a property of the MainWindow. Then this could be consume by the plugins. Right now the minimal_scene only works with "ogre2" (as a default render engine) this PR fix this and allow to set the render engine not only with the sdf but with the command line argument
--render-engine-guiChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge