Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Snackbar qtquick object #369

Merged
merged 6 commits into from Mar 9, 2022
Merged

Added Snackbar qtquick object #369

merged 6 commits into from Mar 9, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 7, 2022

🎉 New feature

Summary

Create a IgnSnackBar QtQuick object to show message to the user in the same manner by plugins

It could be :

  • persistant and then you need to click inside the GUI
  • or with a timeout

snackback

Added snackbar dialog to:

  • Save configuration
  • Teleop topic
  • Snapshot
  • Image view update

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Mar 7, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Mar 7, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Mar 7, 2022
@ahcorde ahcorde mentioned this pull request Mar 7, 2022
8 tasks
@ahcorde ahcorde moved this from Inbox to In review in Core development Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #369 (eb58ef3) into ign-gui3 (fc2f870) will decrease coverage by 0.13%.
The diff coverage is 38.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui3     #369      +/-   ##
============================================
- Coverage     65.96%   65.83%   -0.14%     
============================================
  Files            29       29              
  Lines          3191     3202      +11     
============================================
+ Hits           2105     2108       +3     
- Misses         1086     1094       +8     
Impacted Files Coverage Δ
include/ignition/gui/MainWindow.hh 100.00% <ø> (ø)
src/plugins/screenshot/Screenshot.cc 30.12% <0.00%> (-3.22%) ⬇️
src/plugins/teleop/Teleop.cc 83.19% <37.50%> (-1.77%) ⬇️
src/plugins/image_display/ImageDisplay.cc 24.07% <66.66%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755b995...eb58ef3. Read the comment docs.

@ahcorde ahcorde added the OOBE 📦✨ Out-of-box experience label Mar 7, 2022
@chapulina chapulina linked an issue Mar 7, 2022 that may be closed by this pull request
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the centralized approach using a signal from the MainWindow 👍 This should make it easier to improve the snackbar in the future. For example, in the future, if we start getting too many notifications at once, we may want to implement some logic to display them consecutively.

include/ignition/gui/MainWindow.hh Show resolved Hide resolved
include/ignition/gui/qml/IgnSnackBar.qml Outdated Show resolved Hide resolved
src/plugins/screenshot/Screenshot.cc Outdated Show resolved Hide resolved
src/plugins/teleop/Teleop.cc Outdated Show resolved Hide resolved
include/ignition/gui/qml/IgnSnackBar.qml Outdated Show resolved Hide resolved
@ahcorde ahcorde mentioned this pull request Mar 8, 2022
8 tasks
ahcorde and others added 3 commits March 8, 2022 15:55
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just pushed a small change in eb58ef3 to change the border to a shadow.

Before:

border

After:

shadow

@chapulina chapulina enabled auto-merge (squash) March 9, 2022 19:32
@chapulina chapulina merged commit 5428d26 into ign-gui3 Mar 9, 2022
Core development automation moved this from In review to Done Mar 9, 2022
@chapulina chapulina deleted the ahcorde/3/snackbar branch March 9, 2022 20:01
@chapulina chapulina moved this from Done to Highlights in Core development Mar 10, 2022
@ahcorde ahcorde mentioned this pull request Mar 25, 2022
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification snackbar
3 participants