New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teleop: Refactor and support vertical #440
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #440 +/- ##
============================================
+ Coverage 66.42% 66.88% +0.46%
============================================
Files 29 29
Lines 3291 3310 +19
============================================
+ Hits 2186 2214 +28
+ Misses 1105 1096 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments
Could we add a stop button for the sliders tab (would set forward, velocity, and yaw vel to zero)?
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Done 1c3e5ef |
🎉 New feature
Summary
Adds controls for vertical linear velocity for the teleop plugin. Also made the twist topic configurable from the XML.
I had to refactor quite a bit of code to make the implementation a bit cleaner.
Test it
ign gazebo -r multicopter_velocity_control.sdf
ign gazebo -r diff_drive.sdf
Checklist
Updated migration guide (as needed)Consider updating Python bindings (if the library has them)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸