Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teleop: Refactor and support vertical #440

Merged
merged 6 commits into from Jul 27, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

Adds controls for vertical linear velocity for the teleop plugin. Also made the twist topic configurable from the XML.

I had to refactor quite a bit of code to make the implementation a bit cleaner.

Test it

ign gazebo -r multicopter_velocity_control.sdf

teleop_new

ign gazebo -r diff_drive.sdf

diff_drive_teleop

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Jul 22, 2022
@chapulina chapulina requested a review from jennuine as a code owner July 22, 2022 22:52
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 22, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #440 (489414b) into ign-gui3 (fa98615) will increase coverage by 0.46%.
The diff coverage is 96.05%.

❗ Current head 489414b differs from pull request most recent head 1c3e5ef. Consider uploading reports for the commit 1c3e5ef to get more accurate results

@@             Coverage Diff              @@
##           ign-gui3     #440      +/-   ##
============================================
+ Coverage     66.42%   66.88%   +0.46%     
============================================
  Files            29       29              
  Lines          3291     3310      +19     
============================================
+ Hits           2186     2214      +28     
+ Misses         1105     1096       -9     
Impacted Files Coverage Δ
src/plugins/teleop/Teleop.hh 100.00% <ø> (ø)
src/plugins/teleop/Teleop.cc 92.02% <96.05%> (+8.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa98615...1c3e5ef. Read the comment docs.

@chapulina chapulina moved this from Inbox to In review in Core development Jul 22, 2022
@chapulina chapulina added the enhancement New feature or request label Jul 23, 2022
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments

Could we add a stop button for the sliders tab (would set forward, velocity, and yaw vel to zero)?

src/plugins/teleop/Teleop.cc Outdated Show resolved Hide resolved
src/plugins/teleop/Teleop.cc Outdated Show resolved Hide resolved
src/plugins/teleop/Teleop.cc Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

Could we add a stop button for the sliders tab (would set forward, velocity, and yaw vel to zero)?

Done 1c3e5ef

@chapulina chapulina merged commit e526f03 into ign-gui3 Jul 27, 2022
Core development automation moved this from In review to Done Jul 27, 2022
@chapulina chapulina deleted the chapulina/3/teleop branch July 27, 2022 01:10
@chapulina chapulina moved this from Done to Highlights in Core development Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel enhancement New feature or request OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants