Provide code to replace Scene3D plugin and update Migration.md #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
ahcorde
requested changes
Sep 12, 2022
There was a problem hiding this comment.
Add a link in the Migration.md. Otherwise It's difficult to find this file.
Ouch, I forgot it 8fe6c91 |
jennuine
requested changes
Sep 12, 2022
| @@ -0,0 +1,100 @@ | |||
| <!-- 3D scene --> | |||
There was a problem hiding this comment.
Several of these plugins are gz-sim specific. I suggest removing this file and in the Migration.md replace the provided link with this instead: https://github.com/gazebosim/gz-sim/blob/ff1c82b41e548dfdc8076374f9500db2df2c35a1/examples/worlds/minimal_scene.sdf#L29-L128
There was a problem hiding this comment.
sounds good, thanks 2e2807c
ahcorde
requested changes
Sep 12, 2022
Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
|
Follow in gazebosim/gz-sim#1698 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Bug fix
Fixes #484
Summary
Include code to replace the removed Scene3D plugin so users can just copy/paste. I've updated the Migration.md, there was an old entry from 5.x to 6.x that I'm not sure if can be overwritten.
I would also love to update the console message to point to the code snippet but I was unable to find where the error comes from, gz-sim I assume.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.