Add color palette to plugin settings to change background color #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarathkrishnan Ramesh <sarathkrishnan99@gmail.com>
chapulina
reviewed
May 12, 2020
There was a problem hiding this comment.
Great! This works for me!
It would be great if the color would persist when the configuration is saved. For example:
- Open
ign gui - Add
Publisherplugin - Change its background color to blue
- On the left menu,
Save configuration as - Then
Load configurationand choose the saved file - you'll see that the background goes back to white.
If you inspect the saved file, you'll see that it doesn't have any variables holding the color. I think we'll need to add it as a property of IgnCard.
The plugin_params.config example should also be helpful to look at.
|
Okay! Thanks. I'll look into it. |
* Save plugin background color information in config file * Change default background color to white Signed-off-by: Sarathkrishnan Ramesh <sarathkrishnan99@gmail.com>
chapulina
suggested changes
May 13, 2020
Signed-off-by: Sarathkrishnan Ramesh <sarathkrishnan99@gmail.com>
chapulina
approved these changes
May 13, 2020
chapulina
pushed a commit
that referenced
this pull request
Jun 4, 2020
* Add color palette to plugin settings to change background color * Save plugin background color information in config file Signed-off-by: Sarathkrishnan Ramesh <sarathkrishnan99@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sarathkrishnan Ramesh sarathkrishnan99@gmail.com
Reference to issue #61
Description
Add color palette to select background color and transparency to the plugin settings. User can change the background in both docked and undocked state.
Basic Info
Tested on: Ubuntu 18.04