Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump msgs, transport, and fuel-tools version in Harmonic #210

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 11, 2023

🎉 New feature

Summary

Bumping to use the new msgs, transport, and fuel-tools versions in Harmonic: msgs10, transport13, fuel-tools9

Depends on:
gazebosim/gz-fuel-tools#326

Part of gazebo-tooling/release-tools#878

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Mar 8, 2023

@osrf-jenkins run tests please

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #210 (21fdf96) into main (a892e6a) will not change coverage.
The diff coverage is n/a.

❗ Current head 21fdf96 differs from pull request most recent head 2d87eda. Consider uploading reports for the commit 2d87eda to get more accurate results

@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   56.90%   56.90%           
=======================================
  Files           3        3           
  Lines         413      413           
=======================================
  Hits          235      235           
  Misses        178      178           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033 iche033 marked this pull request as ready for review March 8, 2023 23:33
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Mar 8, 2023

Fixed deprecation warnings to get ubuntu CI green. 2d87eda

@iche033
Copy link
Contributor Author

iche033 commented Mar 9, 2023

CI is working!

@iche033 iche033 merged commit 7e28e78 into main Mar 9, 2023
@iche033 iche033 deleted the bump_msgs_transport_fuel-tools branch March 9, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants