Reviewer feedback

Signed-off-by: Louise Poubel <louise@openrobotics.org>
gazebosim · Sep 15, 2021 · 564de1c · 564de1c
1 parent 8fd565e
commit 564de1c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/include/ignition/math/Vector4.hh b/include/ignition/math/Vector4.hh
@@ -42,7 +42,7 @@ namespace ignition
       /// \brief math::Vector4(1, 1, 1, 1)
       public: static const Vector4<T> One;
 
-      /// \brief math::Vector4(NaN, NaN, NaN)
+      /// \brief math::Vector4(NaN, NaN, NaN, NaN)
       public: static const Vector4 NaN;
 
       /// \brief Constructor

diff --git a/src/ruby/Vector2_TEST.rb b/src/ruby/Vector2_TEST.rb
@@ -267,7 +267,7 @@ def test_nan
 
     nanVec.Correct()
     assert(Ignition::Math::Vector2d.Zero == nanVec,
-           "Corrected vector equals zero")
+           "Corrected vector should equal zero")
 
     nanVecF = Ignition::Math::Vector2f.NaN
     assert(!nanVecF.IsFinite(),
@@ -277,7 +277,7 @@ def test_nan
 
     nanVecF.Correct()
     assert(Ignition::Math::Vector2f.Zero == nanVecF,
-           "Corrected vector equals zero")
+           "Corrected vector should equal zero")
   end
 end
 

diff --git a/src/ruby/Vector3_TEST.rb b/src/ruby/Vector3_TEST.rb
@@ -435,7 +435,7 @@ def test_nan
 
     nanVec.Correct()
     assert(Ignition::Math::Vector3d.Zero == nanVec,
-           "Corrected vector equals zero")
+           "Corrected vector should equal zero")
 
     nanVecF = Ignition::Math::Vector3f.NaN
     assert(!nanVecF.IsFinite(),
@@ -446,7 +446,7 @@ def test_nan
 
     nanVecF.Correct()
     assert(Ignition::Math::Vector3f.Zero == nanVecF,
-           "Corrected vector equals zero")
+           "Corrected vector should equal zero")
   end
 end
 

diff --git a/src/ruby/Vector4_TEST.rb b/src/ruby/Vector4_TEST.rb
@@ -307,7 +307,7 @@ def test_nan
 
     nanVec.Correct()
     assert(Ignition::Math::Vector4d.Zero == nanVec,
-           "Corrected vector equals zero")
+           "Corrected vector should equal zero")
 
     nanVecF = Ignition::Math::Vector4f.NaN
     assert(!nanVecF.IsFinite(),
@@ -319,7 +319,7 @@ def test_nan
 
     nanVecF.Correct()
     assert(Ignition::Math::Vector4f.Zero == nanVecF,
-           "Corrected vector equals zero")
+           "Corrected vector should equal zero")
   end
 end