fix: add header for numeric_limits allowing build on ubuntu 16.04 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scpeters
approved these changes
May 14, 2020
…an build on ubuntu 16.04 Signed-off-by: Andrew Somerville <andy.somerville@gmail.com>
catskul
force-pushed
the
catskul/add-limits-header
branch
from
c1d9e73
to
2b4497c
Compare
chapulina
approved these changes
May 14, 2020
chapulina
pushed a commit
that referenced
this pull request
Jul 7, 2020
…an build on ubuntu 16.04 (#119) Signed-off-by: Andrew Somerville <andy.somerville@gmail.com>
Merged
scpeters
pushed a commit
that referenced
this pull request
Jul 13, 2020
…an build on ubuntu 16.04 (#119) Signed-off-by: Andrew Somerville <andy.somerville@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that libstdc++ must have internally changed implicit header dependency graph such that
limitswas no longer implicitly included.Added explicit dependency on
limitsto make it possible to compileign-mathin ubuntu 16.04