Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master branch updates #195

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Master branch updates #195

merged 1 commit into from
Mar 10, 2021

Conversation

chapulina
Copy link
Contributor

Part of gazebo-tooling/release-tools#416

Summary

Update all usage of master

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from scpeters as a code owner March 8, 2021 22:47
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Mar 8, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #195 (43fefdb) into ign-math6 (7faac05) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #195   +/-   ##
==========================================
  Coverage      99.20%   99.20%           
==========================================
  Files             63       63           
  Lines           6020     6020           
==========================================
  Hits            5972     5972           
  Misses            48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7faac05...43fefdb. Read the comment docs.

@chapulina chapulina moved this from Inbox to In review in Core development Mar 9, 2021
@scpeters
Copy link
Member

scpeters commented Mar 9, 2021

@osrf-jenkins run tests please

@chapulina chapulina enabled auto-merge (squash) March 9, 2021 18:10
@adlarkin adlarkin self-requested a review March 10, 2021 19:58
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick repository search (thanks git grep), and noticed that the link here no longer works. I believe it should be:

https://github.com/RobotLocomotion/drake/blob/master/multibody/tree/rotational_inertia.h

Should we make that change here before merging?

@chapulina chapulina merged commit 19f9372 into ign-math6 Mar 10, 2021
Core development automation moved this from In review to Done Mar 10, 2021
@chapulina chapulina deleted the chapulina/bye_master branch March 10, 2021 20:05
@chapulina
Copy link
Contributor Author

Should we make that change here before merging?

Oops, auto-merge didn't give us a chance. Feel free to open a new PR with that change. Unfortunately, links tend to deteriorate over time 😕

@adlarkin adlarkin mentioned this pull request Mar 10, 2021
7 tasks
@adlarkin
Copy link
Contributor

Oops, auto-merge didn't give us a chance. Feel free to open a new PR with that change. Unfortunately, links tend to deteriorate over time

No worries, I forgot that we picked auto-merge here. Here's a PR with the change: #197

@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants