Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file tree in README to point out pybind11 #558

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 12, 2023

🦟 Bug fix

Summary

A small update to point out we use pybind11 for Python instead of SWIG

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #558 (98ea093) into gz-math7 (bba92d7) will not change coverage.
The diff coverage is n/a.

❗ Current head 98ea093 differs from pull request most recent head 14064b8. Consider uploading reports for the commit 14064b8 to get more accurate results

@@            Coverage Diff            @@
##           gz-math7     #558   +/-   ##
=========================================
  Coverage     94.16%   94.16%           
=========================================
  Files           145      145           
  Lines          9774     9774           
=========================================
  Hits           9204     9204           
  Misses          570      570           

@azeey azeey merged commit b588e52 into gz-math7 Sep 12, 2023
14 checks passed
@azeey azeey deleted the azeey-patch-1 branch September 12, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants