README: update main branch references to gz-math8 #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
iche033
reviewed
Aug 23, 2024
README.md
Outdated
| @@ -82,12 +82,12 @@ Please see the | |||
| # Code of Conduct | |||
|
|
|||
| Please see | |||
| [CODE_OF_CONDUCT.md](https://github.com/gazebosim/gz-sim/blob/main/CODE_OF_CONDUCT.md). | |||
| [CODE_OF_CONDUCT.md](https://github.com/gazebosim/gz-sim/blob/gz-math8/CODE_OF_CONDUCT.md). | |||
There was a problem hiding this comment.
this is in gz-sim repo and the file rarely changes so we can keep it as main?
README.md
Outdated
| Ubuntu Noble | [](https://build.osrfoundation.org/job/gz_math-ci-main-noble-amd64) | ||
| Homebrew | [](https://build.osrfoundation.org/job/gz_math-ci-main-homebrew-amd64) | ||
| Windows | [](https://build.osrfoundation.org/job/gz_math-main-win) | ||
| Test coverage | [](https://codecov.io/gh/gazebosim/gz-math/branch/gz-math8) |
There was a problem hiding this comment.
branch just redirects to main page
Suggested change
| Test coverage | [](https://codecov.io/gh/gazebosim/gz-math/branch/gz-math8) | |
| Test coverage | [](https://codecov.io/gh/gazebosim/gz-math/tree/gz-math8) |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
iche033
approved these changes
Aug 23, 2024
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
ABI checker was failing because we still had some ignition header files in the removed in 7e0fb54 |
|
ABI checker is still failing due to the ignition headers on the base branch |
8 tasks
I split this out into #624 since it's making the ABI checker fail. I'll plan to merge that and then this branch should have clean CI (want to make sure the ABI checker works well on noble) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Part of gazebo-tooling/release-tools#1092
Summary
Update branch references in the README from
maintogz-math8including the jenkins badges and some markdown links.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.