Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JointTrajectory message #106

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Add JointTrajectory message #106

merged 2 commits into from
Dec 7, 2020

Conversation

AndrejOrsula
Copy link
Contributor

This PR adds ignition.msgs.JointTrajectory, which is currently utilised by JointTrajectoryController (PR - gazebosim/gz-sim#473). It provides time-parameterised control signal for each actuated single-axis joint in form of position, velocity, acceleration and effort.

This message is analogous to trajectory_msgs/msg/JointTrajectory. I opened gazebosim/ros_gz#121, which allows conversion of this message type between ROS 2 and Ignition Transport.

Note: There might not be an immediate benefit of including acceleration field, but it is added to keep consistency with the ROS msg.

Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The message definitions look good to me. I just have a small request about documentation.

Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
@chapulina chapulina moved this from Inbox to In review in Core development Dec 7, 2020
@chapulina chapulina self-assigned this Dec 7, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@chapulina chapulina merged commit 0191ac9 into gazebosim:ign-msgs6 Dec 7, 2020
Core development automation moved this from In review to Done Dec 7, 2020
chapulina pushed a commit that referenced this pull request Dec 22, 2020
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
chapulina added a commit that referenced this pull request Dec 22, 2020
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>

Co-authored-by: Andrej Orsula <orsula.andrej@gmail.com>
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants