Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add particle scatter ratio field to particle emitter #162

Merged
merged 2 commits into from
May 11, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 10, 2021

Signed-off-by: Ian Chen ichen@osrfoundation.org

🎉 New feature

Summary

Needed by particle_emitter2 system in ign-gazebo. See gazebosim/gz-sim#791 (comment)

This parameter has also been added to sdf spec in gazebosim/sdformat#547

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@chapulina chapulina moved this from Inbox to In review in Core development May 11, 2021
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 merged commit 325b661 into main May 11, 2021
@iche033 iche033 deleted the particle_scatter_ratio branch May 11, 2021 23:58
Core development automation moved this from In review to Done May 11, 2021
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants