-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions to run the hybrid simulation #17
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignition crashes when I start the simulation. I'm using galactic+ediface, ignition is using the system instance, the ign-omni
workspace is not sourced.
edit: issue was due to some other versions of ignition installed and it's linking to the wrong version.
After many
|
Here you can find a fix #22. Do you mind to try again ? |
The connector is able to run now. But I'm still not able to get the lidar scans. This part in the instructions:
I don't have the lidar prim I also don't see anything in rviz. |
do you mind to try with this branch |
Same results, but i notice that when i listen to
There are no messages when listen on Other than that, the simulation seems to work, I can move the robot etc. |
tutorials/hybrid_simulation.md
Outdated
def __init__(self): | ||
super().__init__('minimal_subscriber') | ||
self.subscription = self.create_subscription( | ||
LaserScan, | ||
'/scan_issac', | ||
self.listener_callback, | ||
10) | ||
self.subscription # prevent unused variable warning | ||
self.publisher_ = self.create_publisher(LaserScan, '/scan', 10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be listening on /scan
and republishing to /scan_issac
instead? I tried changing this but still can't get the sensors to show up.
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few comments that I have about the documentation I went through (tutorials 1 and 2):
After running the last command in https://github.com/ignitionrobotics/ign-omni/blob/ahcorde/hybrid_instructions/tutorials/01_compile.md (colcon build --merge-install --event-handlers console_direct+ --packages-up-to ignition-omniverse1
), I see the following warning (the build seemed to succeed, though):
WARNING:colcon.colcon_cmake.task.cmake.build:Could not run installation step for package 'ignition-omniverse1' because it has no 'install' target
Is this something to worry about, or can it be ignored? If it can be ignored, I think it would be worth mentioning this in the documentation.
In the Run Ignition
section of tutorial 2 (quickstart), I think the following command can be removed because Fortress binaries were installed in tutorial 1:
source ~/ignition-fortress/install/setup.bash
In the Run the connector
section of tutorial 2 (quickstart), it looks like a command is missing (note how there's nothing after And finally run:
:
In the Run IsaacSim
section of tutorial 2 (quickstart), there's an instruction to Launch IsaacSim and activate the live sync
. The gif below this line already has IsaacSim
running, but can instructions be shown on how to start IsaacSim
if it's not running already?
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
Summary
Add instructions to run the hybrid simulation
Test it
Follow this README.md
Remember to checkout this branch in the ign-omni repository.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.