Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actor animation tutorial #144

Merged
merged 5 commits into from
Sep 28, 2020
Merged

Update actor animation tutorial #144

merged 5 commits into from
Sep 28, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 26, 2020

Updates to reflect new changes to the actor animation system in ign-rendering4

  • moved Code section downward to be consistent with other tutorials
  • updated steps of loading and creating the animations
  • described two methods for playing the animations (manual updating bone pose and advancing animation time)

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 26, 2020
@osrf-triage osrf-triage added this to Inbox in Core development Sep 26, 2020
@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   52.07%   52.07%           
=======================================
  Files         143      143           
  Lines       13105    13105           
=======================================
  Hits         6824     6824           
  Misses       6281     6281           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef0388...29c0d45. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tutorials/10_actor_animation_tutorial.md Outdated Show resolved Hide resolved
Core development automation moved this from Inbox to In review Sep 26, 2020
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@chapulina chapulina merged commit 43c42c9 into master Sep 28, 2020
Core development automation moved this from In review to Done Sep 28, 2020
@chapulina chapulina deleted the actor_animation_tutorial branch September 28, 2020 17:42
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants