Update camera tracking tutorial #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=======================================
Coverage 52.07% 52.07%
=======================================
Files 143 143
Lines 13105 13105
=======================================
Hits 6824 6824
Misses 6281 6281 Continue to review full report at Codecov.
|
chapulina
approved these changes
Sep 26, 2020
There was a problem hiding this comment.
A minor suggestion would be to link to the API docs instead of listing the function parameters. i.e. https://ignitionrobotics.org/api/rendering/4.0/classignition_1_1rendering_1_1Camera.html#ae5dac859964f1c47eba4d46d6d3ef9f9
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
|
yep good idea, updated. 47d1e03 |
chapulina
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetWorld*functions. They are useful but not particularly specific to camera tracking. Maybe it'll suit better in a separate tutorial on node transforms in ign-renderingSigned-off-by: Ian Chen ichen@osrfoundation.org