Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gazebo scene viewer tutorial #147

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 26, 2020

  • Fix compilation against gazebo9. When building the examples, it always includes the Helper.hh header from math4 (gz9 dependency) instead of math6, causing compilation error due to missing math::secNsecToDuration function. The changes make sure that the examples are able to build with either math4 or math6 version.
  • moved the Code section to the bottom so that the tutorial layout is consistent with other tutorials

Signed-off-by: Ian Chen ichen@osrfoundation.org

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 26, 2020
@osrf-triage osrf-triage added this to Inbox in Core development Sep 26, 2020
@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   52.07%   52.07%           
=======================================
  Files         143      143           
  Lines       13105    13105           
=======================================
  Hits         6824     6824           
  Misses       6281     6281           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef0388...8c6fb3c. Read the comment docs.

@chapulina chapulina moved this from Inbox to In review in Core development Sep 28, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, I tested against Gazebo 11.

I just have a question and a comment about the image sizes, which is not introduced by this PR.

examples/gazebo_scene_viewer/SceneManager.cc Show resolved Hide resolved
tutorials/11_gazebo_scene_viewer_tutorial.md Show resolved Hide resolved
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@chapulina chapulina merged commit a66c9cc into master Sep 28, 2020
Core development automation moved this from In review to Done Sep 28, 2020
@chapulina chapulina deleted the gazebo_scene_viewer_tutorial branch September 28, 2020 23:44
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants