Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom shaders tutorial #148

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Update custom shaders tutorial #148

merged 3 commits into from
Sep 29, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 26, 2020

  • copied the custom shaders over to the example's own media directory so that demo is self-contained.
  • tweaked the depth camera shaders to produce a nicer grayscale appearance for objects in the scene (it used to be all white which does not really show that the shaders are doing anything)
  • updated tutorial to explain better the two uses of shaders

Signed-off-by: Ian Chen ichen@osrfoundation.org

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 26, 2020
@osrf-triage osrf-triage added this to Inbox in Core development Sep 26, 2020
@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   52.07%   52.07%           
=======================================
  Files         143      143           
  Lines       13105    13105           
=======================================
  Hits         6824     6824           
  Misses       6281     6281           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b27e5a...f36a613. Read the comment docs.

@chapulina chapulina moved this from Inbox to In review in Core development Sep 28, 2020
@chapulina chapulina merged commit 7fd2369 into master Sep 29, 2020
Core development automation moved this from In review to Done Sep 29, 2020
@chapulina chapulina deleted the custom_shaders_tutorial branch September 29, 2020 17:57
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants