👩🌾 Make flaky VisualAt test more verbose #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
changed the title
Codecov Report
@@ Coverage Diff @@
## ign-rendering3 #174 +/- ##
===============================================
Coverage 50.45% 50.45%
===============================================
Files 129 129
Lines 11756 11756
===============================================
Hits 5932 5932
Misses 5824 5824 Continue to review full report at Codecov.
|
iche033
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been flaky for a while, see history:
https://build.osrfoundation.org/job/ignition_rendering-ci-ign-rendering3-bionic-amd64/lastBuild/testReport/(root)/Camera_CameraTest/VisualAt_ogre2/history/
I can't reproduce the failure locally even running the test hundreds of times. So in this PR, I'm changing some conditions so the next time the test flakes, we should at least have more information about how it fails.