Remove some windows warnings #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## ign-rendering4 #183 +/- ##
===============================================
Coverage 52.58% 52.58%
===============================================
Files 143 143
Lines 13333 13333
===============================================
Hits 7011 7011
Misses 6322 6322 Continue to review full report at Codecov.
|
mjcarroll
approved these changes
Dec 7, 2020
|
Window failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related with this other PR gazebosim/gz-sensors#58
There are some Windows warning comming from this package. https://build.osrfoundation.org/job/ign_sensors-pr-win/508/msbuild/new/
Signed-off-by: ahcorde ahcorde@gmail.com