Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert IgnOGRE Windows fix, it breaks downstream libraries #215

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

chapulina
Copy link
Contributor

This was introduced in #206, and now trying to compile ign-gui3 against it I get:

CMake Error at src/plugins/CMakeLists.txt:29 (add_library):
  Target "Grid3D" links to target "IgnOGRE::IgnOGRE" but the target was not               
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?       
Call Stack (most recent call first): 
  src/plugins/CMakeLists.txt:77 (ign_gui_add_library)
  src/plugins/grid_3d/CMakeLists.txt:1 (ign_gui_add_plugin)
                                    
                                     
CMake Error at src/plugins/CMakeLists.txt:29 (add_library):
  Target "Scene3D" links to target "IgnOGRE::IgnOGRE" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?            
Call Stack (most recent call first):  
  src/plugins/CMakeLists.txt:77 (ign_gui_add_library)
  src/plugins/scene3d/CMakeLists.txt:1 (ign_gui_add_plugin)  

I originally did it to fix a Windows warning. Let's see how CI comes back. If Windows is still complaining, we may need a different fix.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added bug Something isn't working Windows Windows support labels Jan 28, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Jan 28, 2021
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jan 28, 2021
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #215 (2e99ff6) into ign-rendering3 (64714e5) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering3     #215   +/-   ##
===============================================
  Coverage           50.34%   50.35%           
===============================================
  Files                 129      129           
  Lines               11782    11782           
===============================================
+ Hits                 5932     5933    +1     
+ Misses               5850     5849    -1     
Impacted Files Coverage Δ
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64714e5...2e99ff6. Read the comment docs.

Core development automation moved this from Inbox to In review Jan 28, 2021
@j-rivero
Copy link
Contributor

No warnings on Windows. Good to go.

@j-rivero j-rivero merged commit eacf43d into ign-rendering3 Jan 28, 2021
Core development automation moved this from In review to Done Jan 28, 2021
@j-rivero j-rivero deleted the chapulina/3/ignogre branch January 28, 2021 14:16
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏰 citadel Ignition Citadel Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants