Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coding style issues #225

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Fix coding style issues #225

merged 2 commits into from
Feb 3, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 2, 2021

No description provided.

@iche033
fix style issues
f28e818 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
fix
6cf3841 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 changed the base branch from ign-rendering4 to ign-rendering3 February 2, 2021 20:48
@osrf-triage osrf-triage added this to Inbox in Core development Feb 2, 2021
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 2, 2021 •
edited

Codecov Report

Merging #225 (6cf3841) into ign-rendering3 (0a54d81) will increase coverage by 0.23%.
The diff coverage is 67.29%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering3     #225      +/-   ##
==================================================
+ Coverage           50.39%   50.63%   +0.23%     
==================================================
  Files                 129      129              
  Lines               11692    11864     +172     
==================================================
+ Hits                 5892     6007     +115     
- Misses               5800     5857      +57
Impacted Files Coverage Δ
include/ignition/rendering/RayQuery.hh 100.00% <ø> (ø)
include/ignition/rendering/RenderPassSystem.hh 100.00% <ø> (ø)
include/ignition/rendering/base/BaseCamera.hh 70.27% <ø> (ø)
include/ignition/rendering/base/BaseDepthCamera.hh 16.66% <ø> (ø)
include/ignition/rendering/base/BaseMarker.hh 43.24% <ø> (ø)
include/ignition/rendering/base/BaseScene.hh 0.00% <ø> (ø)
...clude/ignition/rendering/base/BaseThermalCamera.hh 94.44% <ø> (ø)
...nclude/ignition/rendering/ogre/OgreRenderEngine.hh 100.00% <ø> (ø)
ogre/src/OgreDepthCamera.cc 0.00% <0.00%> (ø)
ogre/src/OgreGpuRays.cc 0.00% <0.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a2e54...6cf3841. Read the comment docs.

Core development automation moved this from Inbox to In review Feb 2, 2021
@iche033
Copy link
Contributor Author

iche033 commented Feb 2, 2021

@osrf-jenkins run tests please

1 similar comment
@iche033
Copy link
Contributor Author

iche033 commented Feb 3, 2021

@osrf-jenkins run tests please

@chapulina chapulina merged commit 445a806 into ign-rendering3 Feb 3, 2021
Core development automation moved this from In review to Done Feb 3, 2021
@chapulina chapulina deleted the style_fix branch February 3, 2021 21:17
nkoenig added a commit that referenced this pull request Feb 10, 2021
@nkoenig @iche033 @chapulina
4 4 0 prep (#242)
f9ddcea 
* Fix coding style issues (#225)

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* ⬆️  3.4.0 (#238)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Update changelog and cmake

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Ian Chen <ichen@osrfoundation.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iche033 @ahcorde @chapulina